Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test PASSWD #531

Merged
merged 8 commits into from
Jun 26, 2023
Merged

test PASSWD #531

merged 8 commits into from
Jun 26, 2023

Conversation

BriocheBerlin
Copy link
Contributor

cc #96

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (eaa06df) 86.08% compared to head (8333926) 86.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   86.08%   86.08%   -0.01%     
==========================================
  Files          59       59              
  Lines        7848     7868      +20     
==========================================
+ Hits         6756     6773      +17     
- Misses       1092     1095       +3     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Number of dependencies and binary size impact report

Metric main PR #531 Delta
Direct dependencies 5 5 -
Total dependencies 10 10 -
Binary size 968.5 KiB 621 KiB -35.9%
Text size 564.6 KiB 364.1 KiB -35.5%
Dependencies diff
 └─ sudo-rs [v0.1.0-dev.20230620]
    ├─ glob [v0.3.1]
    ├─ libc [v0.2.146]
    ├─ log [v0.4.19]
    ├─ signal-hook [v0.3.15]
    |  ├─ libc [v0.2.146]
    |  ├─ signal-hook-registry [v1.4.1]
    |  |  └─ libc [v0.2.146]
    |  └─ cc [v1.0.79]
    └─ signal-hook-registry [v1.4.1]

@BriocheBerlin BriocheBerlin mentioned this pull request Jun 23, 2023
56 tasks
* Removes test which changes the Default !authenticate, not on implementation plan.
* Adds issue numbers to ignores.
* Switches `exec` out for `output`.
@BriocheBerlin BriocheBerlin marked this pull request as ready for review June 23, 2023 17:13
@squell squell self-assigned this Jun 23, 2023
@squell
Copy link
Member

squell commented Jun 23, 2023

I've added a commit that changes the test so it is not failing due to the realpath vs absolute path related reason.

@squell
Copy link
Member

squell commented Jun 26, 2023

Note: once #563 is merged the original paths in the test-cases (pre-commit 8333926) also result in passing test-cases.

@squell squell added this pull request to the merge queue Jun 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 26, 2023
@squell squell added this pull request to the merge queue Jun 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2023
@squell squell added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 4c76e33 Jun 26, 2023
13 checks passed
@japaric japaric deleted the passwd branch June 26, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants