Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The current combination of aggregations and formatting is rather slow, in fact an array of 80.000 randomly generated doubles took about 40 seconds to be formatted into an octave vector string. This alternative implementation only took 47 milliseconds to create the same string. I initially wanted to test the difference on an array filled with zeroes of size 4.000.000, however after about 20 minutes I decided it was taking too long, while the implementation in this pull request only took 614 milliseconds.
What?
The
.ToOctave()
methods have been implemented with aStringBuilder
loop which is considerably faster/more scalable than the current implementation present in the master branch.