Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show document id if total count in cluster is 1 #6

Closed
wants to merge 1 commit into from

Conversation

CGenie
Copy link

@CGenie CGenie commented Jan 9, 2014

When 1 element is returned in faceting, return it's _id property too. That way we can localize it via the GET api and return additional info for it on pins, for example.

@popovae
Copy link

popovae commented Feb 27, 2014

Hello CGenie! Did you find any way to do it?

@CGenie
Copy link
Author

CGenie commented Mar 1, 2014

Hello,
Well, are you asking about commit CGenie@0c2aecf ?

@popovae
Copy link

popovae commented Mar 1, 2014

Hello! Thank you and sorry, I'm new to github)

@RapotOR
Copy link

RapotOR commented Mar 2, 2014

Hello,

Nice! That's a missing feature for sure.
Is it possible to make it more configurable?
Like having an option to retrieve a defined number of document's ID for each markers.
Or an option to retrieve document's ID if the marker count is inferior to a defined number.

Anyway, the commit is already valuable! Thanks.

@CGenie
Copy link
Author

CGenie commented Mar 2, 2014

@RapotOR I guess this is possible, but I don't have much time right now. I'll add this to my todo list though :)

@popovae
Copy link

popovae commented Mar 5, 2014

Sorry for a stupid questions, but i see the names of the files needed to be edited, but I can find them on server...сфт you please tell me where are they located?

@ginaluca
Copy link

Hi @CGenie ,

I'm definitely going to merge this. Only I'll need to do it manually because my code base has changed too much in the meanwhile.

@RapotOR : returning more than one id might make the facet too memory intensive, so for now I prefer to stick with simple feature.

@fbertheuil
Copy link

Hello,

i'm really looking for this feature, when do you think it w'll be available ?

Thank a much.

@RapotOR
Copy link

RapotOR commented Mar 25, 2014

@ginaluca
Ok, I understand. One id is already a nice feature. Thank you.

In my opinion, the memory consumption should be taken in account by the application owner.
For example, I am using a filter based on the map box and a geohash-facet factor adapted to the map zoom. So, the marker count is never really high; only big numbers on each marker. Markers with a count lower than 5 (an example) only appears for zoom on a well-defined area. So, i think it will not be so memory consuming.

I dont know very well Java but I will try to implement those options; at least to see the memory impact.

Regards,

ginaluca pushed a commit that referenced this pull request Mar 28, 2014
@gennadys
Copy link

gennadys commented May 8, 2014

Hi,
When are you planning next update with this feature?

@ginaluca
Copy link

Hi,
I'll try to have a new release by the end of next week.

Greetings,
Gianluca

@ginaluca
Copy link

Released 0.0.15

@ginaluca ginaluca closed this May 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants