Added square example (#41) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktrn
reviewed
Oct 28, 2023
src/square.ts
Outdated
| "Square create customer", | ||
| async () => { | ||
| // Use the Square SDK to send a message to the seller | ||
| const customersApi = squareClient.customersApi; |
There was a problem hiding this comment.
Don't quite get this extra step, please see the next comment.
There was a problem hiding this comment.
Ok.. I did split because of makes more readable.
nicktrn
reviewed
Oct 28, 2023
src/square.ts
Outdated
| // After create a customer you can see it in the Square dashboard | ||
| // at https://squareup.com/dashboard/customers/directory/all | ||
| // See more https://developer.squareup.com/reference/square/customers-api/create-customer | ||
| await customersApi.createCustomer(payload); |
There was a problem hiding this comment.
Can't we just do this?
Suggested change
| await customersApi.createCustomer(payload); | |
| await squareClient.customersApi.createCustomer(payload); |
nicktrn
reviewed
Oct 28, 2023
Thanks. Review again.. |
|
Looks good! |
|
@biplobsd this is great, could you fix conflicts pls and ill merge |
|
@D-K-P Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #41
Summary
Create contract in the
customersApiapiScreen record
Square-example.webm