Merge pull request #175 from SSHari/patch-174

fix: 🐛 handle the array use case first in the stableJson util
triggerdotdev · Oct 17, 2023 · 57361c6 · 57361c6
2 parents 9d63124 + 976a7ab
commit 57361c6
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/app/utilities/stableJson.ts b/app/utilities/stableJson.ts
@@ -7,6 +7,11 @@ export function stableJson(json: unknown, keyOrder: string[] = []): unknown {
     const keyOrder = Object.keys(json[0]);
     return json.map((c) => stableJson(c, keyOrder));
   }
+
+  if (Array.isArray(json)) {
+    return json.map((c) => stableJson(c));
+  }
+
   if (typeof json === "object" && json !== null && keyOrder.length > 0) {
     const keys = Object.keys(json);
     const sortedKeys = keys.sort((a, b) => {
@@ -26,10 +31,6 @@ export function stableJson(json: unknown, keyOrder: string[] = []): unknown {
     return result;
   }
 
-  if (Array.isArray(json)) {
-    return json.map((c) => stableJson(c));
-  }
-
   if (typeof json === "object" && json !== null) {
     const result = {} as Record<string, unknown>;
     for (const key of Object.keys(json)) {

diff --git a/tests/stableJson.test.ts b/tests/stableJson.test.ts
@@ -183,3 +183,25 @@ test("It should order object keys in a similar order as the first object in an a
 }"
 `);
 });
+
+test("It should not convert an array to an object in nested arrays", () => {
+  const json = {
+    data: [
+      [1],
+      [2]
+    ],
+  };
+
+  expect(JSON.stringify(stableJson(json), null, 2)).toMatchInlineSnapshot(`
+"{
+  \\"data\\": [
+    [
+      1
+    ],
+    [
+      2
+    ]
+  ]
+}"
+`);
+});