Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON hero does not allow you to open large JSON files #42

Open
NobleDraconian opened this issue Apr 29, 2022 · 9 comments
Open

JSON hero does not allow you to open large JSON files #42

NobleDraconian opened this issue Apr 29, 2022 · 9 comments

Comments

@NobleDraconian
Copy link

Currently, as of 4/29/22, if you attempt to open a large JSON file (around 22MB), the site does not allow you to open it. It simply acts as if you selected no file!

Usecase : Using JSON hero to browse log files & other automatically generated datastructures.

@bolshoytoster
Copy link

@NobleDraconian are there any errors in the console (f12)?

@ericallam
Copy link
Member

Yup this is a known issue, and is related to how the Column View is implemented. We need to reimplement it using virtualization so we can scale the json documents. This is something that is definitely on the roadmap.

@ubuntudroid
Copy link

ubuntudroid commented May 1, 2022

Sample JSON for you guys to try your implementation against: https://raw.githubusercontent.com/kareltucek/firmware/master/examples/mirroring_keymap.json

@matt-aitken
Copy link
Member

@ericallam I've created a branch with column item virtualization. This is only part of the solution though.

Locally I'm getting RangeError: Maximum call stack size exceeded errors for very large files. I've found two separate causes for this:

  1. Getting related paths, i.e. the getRelatedPathsAtPath function. Example: https://jsonplaceholder.typicode.com/photos
  2. Inferring the types. Example from @ubuntudroid above: https://raw.githubusercontent.com/kareltucek/firmware/master/examples/mirroring_keymap.json

@paulmwatson
Copy link

Great to hear this is on the roadmap as my first test of JSON hero was a 14mb GEOJSON file and it didn't work at all;
https://github.com/OpenUpSA/nu-land-parcel-map/blob/main/src/data/complete.json

@ericallam
Copy link
Member

@paulmwatson thanks for sending us a nice large JSON file to test with!

@migdur
Copy link

migdur commented Oct 4, 2022

Hello, is there any progress on this topic? I can also supply large json files (around 4.7MB) for testing/debugging purposes if needed. Thanks.

@jonaskuiler
Copy link

Hey @ericallam, is there anything I can do to help?

@arunmg007
Copy link

Facing the same issue @ericallam, is this in the roadmap to support large files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants