Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Googlesheets doc for end users #67

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Update Googlesheets doc for end users #67

merged 2 commits into from
Nov 11, 2020

Conversation

cab105
Copy link
Contributor

@cab105 cab105 commented Nov 11, 2020

The original documentation was based off of the developer repo and assumed running on-prem without the bridge. The updated documentation reflects frontend/UI bridge.

Closes #65

@cab105 cab105 added the GA label Nov 11, 2020
@cab105 cab105 added this to the v1.0.0 milestone Nov 11, 2020
@cab105 cab105 self-assigned this Nov 11, 2020
docs/targets/googlesheets.md Outdated Show resolved Hide resolved
docs/targets/googlesheets.md Show resolved Hide resolved

## Using the sink adapter
This event target receives [CloudEvents][ce] over HTTP and sends them to GoogleSheets.
Copy link
Contributor

@antoineco antoineco Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in another PR: we should be slightly more accurate. We don't "send events" to GS, we "use the data from an event's payload to populate a Sheet".

@@ -13,7 +13,7 @@ The following is a list of Triggermesh event destinations known as `Targets`. So
<!-- * [Confluent](./confluent.md): Forward events to Confluent Kafka. -->
* [Datadog](./datadog.md): Forward event payload to Datadog.
* [Elasticsearch](./elasticsearch.md): Send events to Elasticsarch to be indexed.
<!-- * [Googlesheets](./googlesheets.md): Send events to a GoogleSheets. -->
* [Googlesheets](./googlesheets.md): Send events to a GoogleSheets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Googlesheets](./googlesheets.md): Send events to a GoogleSheets.
* [Google Sheets](./googlesheets.md): Send events to a Google Sheet.

@cab105 cab105 merged commit 8c010c8 into master Nov 11, 2020
@cab105 cab105 deleted the googlesheets-doc branch November 11, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate target docs
3 participants