Add Google Cloud Storage Source e2e test #124
Conversation
| // CreateObject creates an object named after the given framework.Framework. | ||
| func CreateObject(storageCli *storage.Client, project string, bucket string, f *framework.Framework) string { | ||
| object := f.UniqueName | ||
| file, err := os.Create("/tmp/" + object) |
There was a problem hiding this comment.
I see the file being created, but where is it being deleted?
There was a problem hiding this comment.
@cab105 I just added the file deletion.
There was a problem hiding this comment.
Do we need to delete though? I haven't looked at the code yet, but I would expect that we simply
- Create a bucket
- Create a file
- Delete the bucket
similarly to other tests (GitHub, etc.)
There was a problem hiding this comment.
We do in this case as the file is created locally first, and then uploaded to GCP. Since these tests can run locally we need to clean up our mess instead of relying on a higher power to do it for us (whether it is in docker or reboot on some unix based systems).
There was a problem hiding this comment.
Oh, didn't understand it that way :) Thanks for the clarification!
Closes #123