Fix loss of sensors #1442
Merged
Fix loss of sensors #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakov
requested changes
Oct 14, 2021
| @@ -113,7 +113,9 @@ QLayout *DevicesConfigurationWidget::initPort(const QString &robotModelName | |||
| } | |||
|
|
|||
| if (mAutosaveMode) { | |||
| connect(comboBox, &QComboBox::currentTextChanged, this, &DevicesConfigurationWidget::save); | |||
| connect(comboBox, &QComboBox::currentTextChanged, this, [this](){ | |||
| propagateChangesFromBox(static_cast<QComboBox *>(sender())); | |||
| void DevicesConfigurationWidget::propagateChanges(const PortInfo &port, const DeviceInfo &sensor) | ||
| void DevicesConfigurationWidget::propagateChangesFromBox(QComboBox *box) | ||
| { | ||
| const PortInfo port = box->property("port").value<PortInfo>(); |
There was a problem hiding this comment.
Suggested change
| const PortInfo port = box->property("port").value<PortInfo>(); | |
| const PortInfo &port = box->property("port").value<PortInfo>(); |
| void DevicesConfigurationWidget::propagateChangesFromBox(QComboBox *box) | ||
| { | ||
| const PortInfo port = box->property("port").value<PortInfo>(); | ||
| const DeviceInfo device = box->itemData(box->currentIndex()).value<DeviceInfo>(); |
There was a problem hiding this comment.
Suggested change
| const DeviceInfo device = box->itemData(box->currentIndex()).value<DeviceInfo>(); | |
| const DeviceInfo &device = box->itemData(box->currentIndex()).value<DeviceInfo>(); |
IKhonakhbeeva
force-pushed
the
sensors
branch
from
a4f57d8
to
59deb54
Compare
IKhonakhbeeva
force-pushed
the
sensors
branch
from
59deb54
to
a8fef16
Compare
iakov
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.