Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex Pages: Frontend issues with plugin events (changes do not stick) #5

Open
mahagr opened this issue Sep 19, 2019 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@mahagr
Copy link
Contributor

mahagr commented Sep 19, 2019

Due to differences in how the pages are cached, plugins making changes to the page objects during the events: onBuildPagesInitialized, onPageProcessed and onFolderProcessed will not be cached right now, causing the changes to be lost on later requests.

This issue needs to be solved as soon as possible.

@mahagr mahagr added the bug Something isn't working label Sep 19, 2019
@rhukster
Copy link
Member

Not sure if all these event issues are based in the same fundamental problem, but onPageProcessed is used extensively. The other 2 not as much.

@mahagr
Copy link
Contributor Author

mahagr commented Oct 7, 2019

The fix from above calls onPageProcessed every time a page is accessed first time during the request. While not ideal, it seems to fix most of the issues with plugins.

I still need to figure out how to efficiently cache the changes made by plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants