Fix default stemmer (again)

[ViliusS]

TNTSearch changed default stemmer again teamtnt/tntsearch@b675c62.

To make our plugin behaviour consistent I would like to propose to remove 'default' value, use 'NoStemmer' as default and always set stemmer in the code.

Not sure if there is a better way to not break compatibility with older configs, it could produce errors, but everyone who have used 'default' previously should be aware about the change upstream anyway.

[rhukster]

I think that we still need to handle the case where stemmer is set to default as this was the default before and people could well have saved this value.. So if default use noStemmer ?

[ViliusS]

I can re-add

      if ($this->options['stemmer'] == 'default') {
           $indexer->setLanguage('no');
       } else {
           $indexer->setLanguage($this->option['stemmer']);
       }

to setIndex(). Is this enough or do I need to change it in other places?

[rhukster]

I think that would be fine.

[ViliusS]

Done.

[ViliusS]

Just a reminder to merge :)

[ViliusS]

@rhukster could you merge this and check if tntsearch library is up-to-date with upstream changes in https://github.com/teamtnt/tntsearch/pull/243/files ? Broken stemmers give people issues.

[rhukster]

done! sorry slipped through the cracks.

[ViliusS]

Thank you! Could you also update tntsearch library to the latest version?