New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no jquery searches #12
Conversation
Amazing 👍 thank you @apotropaic |
FYI i'm looking at this today. There are a few issues with this implementation that i noticed and that i want to fix. |
…ns (fixes trilbymedia#10) Also pass in_page property to the js
Got the initial rework in:
Pretty much as you had it already @apotropaic, just restructured and hooked up webpack. Also fixed a few issues as well:
I still need to implement the live URI update on the search page so this PR is still not quite done yet. Cheers |
Looks awesome! I was going for a no import solution, but makes sense if you are going to use webpack to just pull in the tools you need, like domready and lodash. One thought I just had was about using fetch, would it be worth it to include a polyfill for that? I'm sure its got something like 80% coverage, but just a thought. And when this is merged, we need to update the learn.getgrav.org website asap! I hit enter almost every time I do an advanced search on that site haha |
I’m already using GitHub’s fetch as polyfill and handling it via webpack: Should be enough for backward compatibility. Also yes as soon as I’m done with the missing bit I’ll test the learn and make sure we get that updated as well 😄 |
History has been now implemented. I'm going to be finally merging this PR on monday. |
Merged, thank you so much for your help with this @apotropaic 👍 |
I didn't have time to write the code for a dropdown, but here is a working js for the input field. I saw the need on issue #2