Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: #10648 deletes necessary files #11101

Closed
dridzal opened this issue Oct 4, 2022 · 6 comments
Closed

Framework: #10648 deletes necessary files #11101

dridzal opened this issue Oct 4, 2022 · 6 comments
Assignees
Labels
client: Sierra All issues that primarily impacts SNL Sierra codes CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests

Comments

@dridzal
Copy link
Contributor

dridzal commented Oct 4, 2022

Bug Report

@trilinos/framework

Description

The checkin test script, cmake/std/sems/checkin-test-sems.sh, used, for instance, by @trilinos/rol for the two-way repo merge, no longer works due to #10648 and related commits. It appears that the cmake files required for configure/test have been removed without consideration of consequences.

Steps to Reproduce

Run the checkin test script. It will fail with

-- Reading in configuration options from cmake/std/GCC-4.8.4-OpenMPI-1.10.1-MpiReleaseDebugSharedPtOpenMP.cmake ...
CMake Error at cmake/tribits/core/package_arch/TribitsGlobalMacros.cmake:180 (include):
  include could not find load file:

    cmake/std/GCC-4.8.4-OpenMPI-1.10.1-MpiReleaseDebugSharedPtOpenMP.cmake
@dridzal dridzal added the type: bug The primary issue is a bug in Trilinos code or tests label Oct 4, 2022
@dridzal dridzal added client: Sierra All issues that primarily impacts SNL Sierra codes PA: Framework Issues that fall under the Trilinos Framework Product Area labels Oct 4, 2022
@e10harvey
Copy link
Contributor

@bartlettroscoe
Copy link
Member

@dridzal, the solution is to upgrade the checkin-tests-sems.sh script to use the GenConfig system. That is a much more complex system (e.g. having to run a separate script to get needed files, symlinks getting created, etc.) but it works and it is supported by the Trilinos framework team.

Let's schedule a time later this week to go over what needs to be done. It should not take long to get your sync process updated to use a GenConfig configuration.

@dridzal
Copy link
Contributor Author

dridzal commented Oct 4, 2022

@bartlettroscoe: Can we do anything right away? We are looking at some time-sensitive deliveries. Can we just back out the changes that remove the necessary files?

@bartlettroscoe
Copy link
Member

Can we do anything right away?

@dridzal, you could, just this one time, cross your fingers and manually do the sync each way, perhaps with just a local build of ROL using any approach that your team is already using to sync from the main repo to your ROL repo and rely on the PR builds for syncing from your ROL repo back to the main Trilinos repo.

Otherwise, updating checkin-test-sems.sh to use a GenConfig PR build should not be very hard.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Oct 7, 2023
Copy link

github-actions bot commented Nov 8, 2023

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Nov 8, 2023
@github-actions github-actions bot closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: Sierra All issues that primarily impacts SNL Sierra codes CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants