Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill out CONTRIBUTING.md #1823

Closed
jmgate opened this issue Oct 6, 2017 · 3 comments
Closed

Fill out CONTRIBUTING.md #1823

jmgate opened this issue Oct 6, 2017 · 3 comments
Assignees
@jmgate
Labels
Framework tasks Framework tasks (used internally by Framework team) process improvement

Comments

@jmgate
Copy link
Contributor

jmgate commented Oct 6, 2017 •
edited

A the moment, CONTRIBUTING.md just has some placeholder text in it. We need to fill it out such that potential contributors understand what is expected when interacting with Trilinos. I can take a crack at this, but I won't be able to start on it till late next week.

@jwillenbring, @bmpersc, any requests as to content?

@trilinos/framework
@jmgate jmgate added Framework tasks Framework tasks (used internally by Framework team) process improvement labels Oct 6, 2017
@jmgate jmgate self-assigned this Oct 6, 2017
@jmgate jmgate mentioned this issue Oct 6, 2017
Merged
@jmgate jmgate added the stage: ready The issue is ready to be worked in a Kanban-like process label Oct 6, 2017
@maherou
Copy link
Member

maherou commented Oct 6, 2017

@jmgate: Please start a draft as you have time. No need to wait.

jmgate added a commit to jmgate/Trilinos that referenced this issue Oct 12, 2017
@jmgate
Fill out CONTRIBUTING.md (trilinos#1823)
f0f171e 
The basics of creating any issue, working it, and submitting a pull
request are now here.  We'll likely want to refine what's in here
though.
jmgate added a commit to jmgate/Trilinos that referenced this issue Oct 12, 2017
@jmgate
Fill out CONTRIBUTING.md (trilinos#1823)
7c7c04e 
The basics of creating an issue, working it, and submitting a pull
request are now here.  We'll likely want to refine what's in here
though.
@jmgate jmgate mentioned this issue Oct 12, 2017
Merged
jmgate added a commit to jmgate/Trilinos that referenced this issue Oct 30, 2017
@jmgate
Fill out CONTRIBUTING.md (trilinos#1823)
f4916a7 
The basics of creating an issue, working it, and submitting a pull
request are now here.  We'll likely want to refine what's in here
though.
jmgate added a commit that referenced this issue Nov 2, 2017
@jmgate
Fill out CONTRIBUTING.md (#1823)
421499e 
Fixing the command to add trilinos/Trilinos as the upstream remote.
@jmgate
Copy link
Contributor Author

jmgate commented Nov 2, 2017

An initial cut of the CONTRIBUTING.md file has made it into develop. When creating a new issue, GitHub provides a link to this file, though that will still contain the placeholder text until these changes make it into master. Users have the ability to select the develop branch from the drop-down menu, revealing the actual contents, but they won't know to do that. I'll leave this issue open until the next develop to master update.

jmgate added a commit that referenced this issue Nov 2, 2017
@jmgate
Fill out CONTRIBUTING.md (#1823)
a037ec6 
Updating README.md to point potential contributors to our contributing
policy.
@jmgate
Copy link
Contributor Author

jmgate commented Nov 8, 2017

These changes have made it into master. Closing…

@jmgate jmgate closed this as completed Nov 8, 2017
@jmgate jmgate removed the stage: ready The issue is ready to be worked in a Kanban-like process label Nov 8, 2017
jmgate added a commit that referenced this issue Nov 8, 2017
@jmgate
Mentioning GitHub Issue Numbers (#1583 & #1823)
ecb48a0 
Our contributing guidelines and pull request template now specify that
commit messages should include all appropriate GitHub issue numbers in
them for the sake of traceability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmgate jmgate

Labels
Framework tasks Framework tasks (used internally by Framework team) process improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maherou @jmgate