ifpack2: fix ambiguous MDF unit test #12078

tmranse · 2023-07-25T22:42:20Z

Fixes issue with ambiguous MDF unit with multiple valid permutations so that it is not sensitive to locale (order of operations, etc).

@trilinos/ifpack2

tmranse · 2023-07-25T22:44:00Z

@ndellingwood @lucbv this PR (along with kokkos/kokkos-kernels#1916) should address kokkos/kokkos-kernels#1901

ndellingwood

@tmranse thanks for the work on this! Changes look reasonable, but just to clarify are these independent of kokkos/kokkos-kernels#1916 ? If not, there will need to be some Kokkos version if-guards to preserve the behavior compatible with Trilinos develop branch

tmranse · 2023-07-25T23:52:45Z

@ndellingwood correct neither change should be affected by the version of the other, they're just two issues that contributed to the failure. So I think we're ok without if-guards here.

trilinos-autotester · 2023-07-26T12:57:11Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2023-07-26T12:58:59Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2554
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1082
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1074
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1073
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2294
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2076
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 715
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Using Repos:

Repo: TRILINOS (tmranse/Trilinos)

Pull Request Author: tmranse

trilinos-autotester · 2023-07-26T15:14:51Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2554
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1082
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1074
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1073
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2294
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2076
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 715
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`f8afe73`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6ce7a1`

CDash Test Results for PR# 12078.

Wiki: How to Reproduce PR Testing Builds and Errors.

ndellingwood · 2023-07-26T16:48:51Z

Failures in the gnu/8.3.0 and clang/11.0.1 builds, here are output snips:

Ifpack2_MDF

2. Ifpack2MDF_double_int_longlong_Test2_UnitTest ... 
 Test that code {prec.setParameters(params);} does not throw : passed
 Comparing prec.getReversePermutations() == refPermuations ... 
 Error, prec.getReversePermutations()[0] = 1 == refPermuations[0] = 5: failed!
 
 Error, prec.getReversePermutations()[6] = 5 == refPermuations[6] = 3: failed!
 
 Error, prec.getReversePermutations()[7] = 3 == refPermuations[7] = 0: failed!
 
 Error, prec.getReversePermutations()[8] = 0 == refPermuations[8] = 1: failed!
 Comparing prec.getPermutations() == refPermuationsInv ... 
 Error, prec.getPermutations()[0] = 8 == refPermuationsInv[0] = 7: failed!
 
 Error, prec.getPermutations()[1] = 0 == refPermuationsInv[1] = 8: failed!
 
 Error, prec.getPermutations()[3] = 7 == refPermuationsInv[3] = 6: failed!
 
 Error, prec.getPermutations()[5] = 6 == refPermuationsInv[5] = 0: failed!
 
 p=0: *** Caught standard std::exception of type 'std::runtime_error' :
 
  ../Trilinos/packages/ifpack2/src/Ifpack2_LocalSparseTriangularSolver_def.hpp:725:
  
  Throw number = 1
  
  Throw test that evaluated to true: (A_crs_->getLocalNumRows() > 0 && this->uplo_ == "N")
  
  Ifpack2::LocalSparseTriangularSolver<Tpetra::RowMatrix<double, int, long long, Tpetra::KokkosCompat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > >::localTriangularSolve: The matrix is neither upper triangular or lower triangular.  You may only call this method if the matrix is triangular.  Remember that this is a local (per MPI process) property, and that Tpetra only knows how to do a local (per process) triangular solve.
 [FAILED]  (0.000986 sec) Ifpack2MDF_double_int_longlong_Test2_UnitTest
 Location: ../Trilinos/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestMDF.cpp:294

Ifpack2_unit_tests

...
p=0 | 35. Ifpack2MDF_double_int_longlong_Test1_UnitTest ... [Passed] (0.00219 sec)
p=0 | 36. Ifpack2MDF_double_int_longlong_Test2_UnitTest ... 
p=0 |  Test that code {prec.setParameters(params);} does not throw : passed
p=0 |  Comparing prec.getReversePermutations() == refPermuations ... 
p=0 |  Error, prec.getReversePermutations()[0] = 1 == refPermuations[0] = 5: failed!
p=0 |  
p=0 |  Error, prec.getReversePermutations()[6] = 5 == refPermuations[6] = 3: failed!
p=0 |  
p=0 |  Error, prec.getReversePermutations()[7] = 3 == refPermuations[7] = 0: failed!
p=0 |  
p=0 |  Error, prec.getReversePermutations()[8] = 0 == refPermuations[8] = 1: failed!
p=0 |  Comparing prec.getPermutations() == refPermuationsInv ... 
p=0 |  Error, prec.getPermutations()[0] = 8 == refPermuationsInv[0] = 7: failed!
p=0 |  
p=0 |  Error, prec.getPermutations()[1] = 0 == refPermuationsInv[1] = 8: failed!
p=0 |  
p=0 |  Error, prec.getPermutations()[3] = 7 == refPermuationsInv[3] = 6: failed!
p=0 |  
p=0 |  Error, prec.getPermutations()[5] = 6 == refPermuationsInv[5] = 0: failed!
p=0 |  
p=0 |  p=0: *** Caught standard std::exception of type 'std::runtime_error' :
p=0 |  
p=0 |   ../Trilinos/packages/ifpack2/src/Ifpack2_LocalSparseTriangularSolver_def.hpp:725:
p=0 |   
p=0 |   Throw number = 3
p=0 |   
p=0 |   Throw test that evaluated to true: (A_crs_->getLocalNumRows() > 0 && this->uplo_ == "N")
p=0 |   
p=0 |   Ifpack2::LocalSparseTriangularSolver<Tpetra::RowMatrix<double, int, long long, Tpetra::KokkosCompat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > >::localTriangularSolve: The matrix is neither upper triangular or lower triangular.  You may only call this method if the matrix is triangular.  Remember that this is a local (per MPI process) property, and that Tpetra only knows how to do a local (per process) triangular solve.
p=0 |  [FAILED]  (0.000795 sec) Ifpack2MDF_double_int_longlong_Test2_UnitTest
p=0 |  Location: ../Trilinos/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestMDF.cpp:294
...

tmranse · 2023-07-26T22:06:43Z

Failures in the gnu/8.3.0 and clang/11.0.1 builds, here are output snips:

@lucbv The root issue happening here is that the old version of this Trilinos test has identical discarded fill in all rows on the first iteration, but in floating points they might be slightly different and our tie breakers aren't applied. This change fixes the test to avoid that issue, but now hits the initialization issue fixed in kokkos/kokkos-kernels#1916 . Alternatively we could replace the checks on if discarded fill are equal with some |delta fill| < eps test but I'm not sure really need to impose the result is consistent across platforms in general?

@ndellingwood The KK change is definitely a bug fix so I'm not sure I want to if-guard back to the old wrong behavior in Trilinos. I also don't want to reconfigure the test to pass by avoiding that bug because I want it covered in the future. I think its perhaps better to just keep this test disabled in Trilinos until the next Kokkos Kernels integration in Trilinos.

Do either of you have thoughts?

ndellingwood · 2023-07-26T22:24:24Z

@tmranse I think once kokkos/kokkos-kernels#1916 makes it through CI and merges it can be cherry-picked to this PR as an emergency bug-fix to Trilinos (this differs from our usual convention of merging kokkos-kernels changes primarily with release snapshots, but emergency bug fixes can merit this). @lucbv are you okay with this plan, or would you prefer to have the ifpack2 mdf tests disabled in Trilinos until the next release?

tmranse · 2023-07-27T00:00:57Z

FWIW I just checked and the existing test passes if I change the == logic to KAS::abs(discarded_fill(src_perm) - discarded_fill(dst_perm)) < KAS::epsilon()*10.0 so that would also be a viable option.

tmranse · 2023-08-02T20:47:36Z

@lucbv any thoughts on these options? looks like you merged kokkos/kokkos-kernels#1916 so maybe cherrypicking is the easiest path forward?

ndellingwood · 2023-08-15T16:49:57Z

@tmranse if you don't mind, please go ahead and cherry-pick kokkos/kokkos-kernels#1916 to the PR. I will review after the cherry-pick to ensure no files are clobbered with other bug-fixes merged to Trilinos

lucbv · 2023-08-17T17:30:45Z

Thanks @ndellingwood and @tmranse for this PR and sorry for the slow response, I created #12140 to cherry pick the changes from Kokkos Kernels. I am hoping this won't take long to merge with Trilinos and we should be able to rebase and retest this one?

ndellingwood · 2023-08-17T17:32:48Z

Thanks @lucbv !

tmranse · 2023-08-17T22:33:09Z

@ndellingwood @lucbv looks like #12140 on its own has the same problem of being sensitive to the ambiguous test. cherrypicked here so the changes can go through together

lucbv · 2023-08-17T22:34:49Z

Thanks @tmranse in that case I will wait to see how testing goes here and we might just close the other PR if that happens.

lucbv

Looks fine to me

trilinos-autotester · 2023-08-17T23:23:59Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2023-08-17T23:24:02Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2023-08-17T23:25:55Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2672
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1194
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1184
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1183
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2401
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2186
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 825
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Using Repos:

Repo: TRILINOS (tmranse/Trilinos)

Pull Request Author: tmranse

trilinos-autotester · 2023-08-18T02:16:12Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2023-08-18T02:21:21Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2673
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1195
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1185
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1184
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2402
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2187
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 826
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Using Repos:

Repo: TRILINOS (tmranse/Trilinos)

Pull Request Author: tmranse

trilinos-autotester · 2023-08-18T05:28:52Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2673
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1195
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1185
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1184
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2402
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2187
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 826
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	type: bug;AT: RETEST;client: SPARC;AT: PRE-TEST INSPECTED
PULLREQUESTNUM	12078
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tmranse/mdfUnit
TRILINOS_SOURCE_REPO	https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA	`ef5deb7`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`e9cbc3c`

CDash Test Results for PR# 12078.

trilinos-autotester · 2023-08-18T05:29:10Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

trilinos-autotester · 2023-08-18T05:29:17Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

…s:develop' (cddbf30). * trilinos-develop: (39 commits) KokkosSparse_spmv_bsrmatrix_impl.hpp: const scalars are still scalars Stokhos: Remove random access memory trait in PCE spmv specializations Stokhos: make view array assignment with random-access LHS work Disallow non-scalar types in KokkosKernels BsrMatrix SpMV Tpetra_BlockCrsMatrix_def.hpp: Use KokkosSparse::spmv MueLu: Removing H2D/D2H transfers in CoordinatesTransferFactory (at least for scalar pdes) ifpack2: fix ambiguous MDF unit test (trilinos#12078) Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool added some new comments about lowCommMakeColMap serial vs device Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path added range policy to parallel loops Reverted execution space changes on views removing extraneous files from lowCommunicationMakeColMap PR changed execution space for Kokkos views, added selection for serial vs CUDA on lowCommMakeColMap explicitly specified the execution space of the ColIndices device view moved colind_LID device to host for case when NumRemoteColGIDs=0 ...

* ifpack2: fix ambigous MDF unit test * Kokkos-Kernels: cherry pick of fixes needed for Ifpack2 MDF

tmranse mentioned this pull request Jul 25, 2023

Trilinos nightly test failures (all backends) in Ifpack2 kokkos/kokkos-kernels#1901

Closed

tmranse mentioned this pull request Jul 25, 2023

mdf: fix initial value in select pivot functor kokkos/kokkos-kernels#1916

Merged

tmranse requested review from jhux2, ndellingwood, lucbv and csiefer2 July 25, 2023 22:44

ndellingwood reviewed Jul 25, 2023

View reviewed changes

ndellingwood added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Jul 25, 2023

ndellingwood previously approved these changes Jul 25, 2023

View reviewed changes

lucbv mentioned this pull request Aug 17, 2023

Kokkos-Kernels: cherry pick of fixes needed for Ifpack2 MDF #12140

Closed

tmranse added 2 commits August 17, 2023 16:25

ifpack2: fix ambigous MDF unit test

24bec5b

Kokkos-Kernels: cherry pick of fixes needed for Ifpack2 MDF

ef5deb7

tmranse dismissed ndellingwood’s stale review via ef5deb7 August 17, 2023 22:32

tmranse force-pushed the tmranse/mdfUnit branch from f8afe73 to ef5deb7 Compare August 17, 2023 22:32

tmranse added AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration client: SPARC Issues related to or needed more specifically by the ATDM SPARC code labels Aug 17, 2023

tmranse added the type: bug The primary issue is a bug in Trilinos code or tests label Aug 17, 2023

lucbv approved these changes Aug 17, 2023

View reviewed changes

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Aug 18, 2023

tmranse merged commit 01e8b1b into trilinos:develop Aug 18, 2023
3 checks passed

tmranse deleted the tmranse/mdfUnit branch August 18, 2023 14:50

cwpearson pushed a commit to cwpearson/Trilinos that referenced this pull request Sep 19, 2023

ifpack2: fix ambiguous MDF unit test (trilinos#12078)

5e0678d

* ifpack2: fix ambigous MDF unit test * Kokkos-Kernels: cherry pick of fixes needed for Ifpack2 MDF

ifpack2: fix ambiguous MDF unit test #12078

ifpack2: fix ambiguous MDF unit test #12078

Conversation

tmranse commented Jul 25, 2023

tmranse commented Jul 25, 2023

ndellingwood left a comment

Choose a reason for hiding this comment

tmranse commented Jul 25, 2023 • edited

trilinos-autotester commented Jul 26, 2023

trilinos-autotester commented Jul 26, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Jul 26, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

ndellingwood commented Jul 26, 2023

tmranse commented Jul 26, 2023 • edited

ndellingwood commented Jul 26, 2023

tmranse commented Jul 27, 2023 • edited

tmranse commented Aug 2, 2023

ndellingwood commented Aug 15, 2023

lucbv commented Aug 17, 2023

ndellingwood commented Aug 17, 2023

tmranse commented Aug 17, 2023

lucbv commented Aug 17, 2023

lucbv left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Aug 17, 2023

trilinos-autotester commented Aug 17, 2023

trilinos-autotester commented Aug 17, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

tmranse commented Jul 25, 2023 •

edited

tmranse commented Jul 26, 2023 •

edited

tmranse commented Jul 27, 2023 •

edited