ROL Trilinos Sync 18-May-2018 #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Trilinos into boost-parameter-list
…ircuit-simoprt and topology-optimization
…dson/ROL-Trilinos into boost-parameter-list
…dson/ROL-Trilinos into boost-parameter-list
…-Trilinos into boost-parameter-list
…eDifference now only approximates derivatives of scalar- and vector-valued functions using the finite difference approximation. ValidateFunction calls FiniteDifference for check_derivative. ValidateFunction also implements check_symmetry, check_adjoint_consistency, and check_inverse. Aliases for scalar, vector, and directional derivative functions moved to ROL::FunctionBindings. Added fix_direction and fix_position methods for partial specification of function arguments.
…d potential conflict with Boost. Activated test for FiniteDifference/ValidateFunction
…FOR_EXCEPTION,
which has the following CMake configuration choices:
- ROL_stacktrace:STRING="Teuchos::stacktrace" (default)
Which replaces the macro TEUCHOS_TEST_FOR_EXCEPTION
- ROL_stacktrace:STRING="boost::stacktrace" ( untested - stub implemented )
- ROL_stacktrace:STRING="backward-cpp"
Which calls uses the stacktrace provided by the header backward.hpp. See
the repository: https://github.com/bombela/backward-cpp
- ROL_stacktrace:STRING="noop"
Which is the no-operation implementation that simply throws the exception
if the first argument evaluates to true. Intended for RELEASE builds.
- Replaced calls to TEUCHOS_TEST_FOR_EXCEPTION to ROL_TEST_FOR_EXCEPTION
throughout the package.
…apters/teuchos/src. Corresponding tests moved as well. CMakeLists for Tpetra adapter and various Teuchos::Comm dependent examples updated to include headers from their new locations. PinT components not yet moved
…twise::EReductionType and ROL::Elementwise::REDUCE_XYZ
…ROL_ParameterList. Moved src/vector/ROL_MultiVector.hpp to adapters/teuchos/src/vector due to dependence on Teuchos::SerialDenseMatrix
…now only copies from rol/src, excluding src/zoo/testproblems
…us directories in adapters/mpi
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: dridzal |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
bartlettroscoe
approved these changes
May 19, 2018
There was a problem hiding this comment.
I fetched this branch locally and ran:
$ git diff --dirstat=0 dridzal/rol-trilinos-sync \
`git merge-base dridzal/rol-trilinos-sync github/develop`
and I verified that all 538 files changes were isolated to the package/rol/ directory.
Therefore, I will assume that ROL developers reviewed all of those changes and therefore I approve.
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/rol
Description
Regular merge between the ROL-Trilinos repo and the main Trilinos repo, via a Trilinos fork.
How Has This Been Tested?
Trilinos check-in tests, performed in ROL-Trilinos and in the Trilinos fork.