Add tokens section #1467
Add tokens section #1467
Conversation
OKendigelyan
force-pushed
the
add-tokens-section
branch
2 times, most recently
from
6d7c77a
to
f09dcab
Compare
| import { useColor } from "../../styles/useColor"; | ||
|
|
||
| // Known verified tokens on mainnet | ||
| const verifiedTokens = [ |
There was a problem hiding this comment.
I think it's worth moving to umami/tezos
| @@ -11,29 +12,24 @@ body { | |||
| } | |||
|
|
|||
| @media (max-width: 768px) { | |||
| padding: 0; | |||
| padding: 0 !important; | |||
There was a problem hiding this comment.
what was wrong with the previous approach?
There was a problem hiding this comment.
Modal overlay adds additional padding to the body and it breaks the layout
| @@ -200,6 +262,7 @@ const theme = extendTheme({ | |||
| }, | |||
| }, | |||
| ":root": { | |||
| "--chakra-colors-black": mode(dark.grey.white, light.grey.white)(props), | |||
There was a problem hiding this comment.
black is white in the light mode and vice versa 🤪
| import repeat from "lodash/repeat"; | ||
|
|
||
| // TODO: move this to utils | ||
| const getSmallestUnit = (decimals: number): string => { |
There was a problem hiding this comment.
looks like it can be moved to umami/core
| tokenDecimals, | ||
| tokenSymbolSafe, | ||
| } from "@umami/core"; | ||
| import repeat from "lodash/repeat"; |
There was a problem hiding this comment.
IIRC we prohibit default imports somewhere 🤔
There was a problem hiding this comment.
I'm not sure why do we prohibited default imports from 3rd party libs?
| @@ -26,14 +28,9 @@ export const AccountSelector = () => { | |||
| </Text> | |||
| <Flex alignItems="center" gap="4px"> | |||
| <Text color={color("700")} size="sm"> | |||
| {accounts[0].label} | |||
| {formatPkh(accounts[0].address.pkh)} | |||
There was a problem hiding this comment.
why so? IIRC we should show both the label and the address
There was a problem hiding this comment.
According to design there should be only account address
OKendigelyan
force-pushed
the
add-tokens-section
branch
from
144a08d
to
7886fc7
Compare
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist