SocialAuth Integration #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the package-lock.json can be deleted, because we use yarn? |
AndreasGassmann
approved these changes
Apr 11, 2023
leoparis89
reviewed
Apr 11, 2023
|
needs a rebase on main |
leoparis89
reviewed
Apr 11, 2023
leoparis89
reviewed
Apr 11, 2023
leoparis89
reviewed
Apr 12, 2023
package-lock.json
Outdated
There was a problem hiding this comment.
package-lock is not used in the project
|
We need to fix the tests |
leoparis89
force-pushed
the
feat/web3-auth
branch
3 times, most recently
from
f4368f1
to
27b0b44
Compare
Tezos methods now take sk and no longer esk + password
leoparis89
force-pushed
the
feat/web3-auth
branch
from
27b0b44
to
833554a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add social auth & signing for Google.
Asana: https://app.asana.com/0/1204165186238194/1204246055017547/f
Types of changes
Put an
xin the boxes that applyChecklist
Further comments
We probably have to transfer the OAuth registration to Trili.