-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace/Fix spdlog or implement a simple logger #56
Comments
I'm taking a look how do a simple lightweight logger for our needs. I could do a try to doing it. |
Assigned you @Zardoz89 as per your comment. (Accidentally assigned myself first because the GitHub Issues interface is balls). |
@Zardoz89 could you provide details on how it clashes with ASIO? I would lke to fix this issue in spdlog |
If I include asio before spdlog, spdlog throws and error about The solution was a preprocessor define of _WIN32_WINNT=600 (number might
|
A quick fix would be to comment out line #170 in spdlog/details.os.h (and not use the z flag in the log pattern) This will remove the need to define the offending =600 macro |
I am going to close this issue for now as a fix is there, albeit not a pretty one. |
@adam4813 Is the fix actually implemented? |
Derp. I realized I forgot to push it. I will push it later tonight.
|
Actually I did commit this on my fork in the networking branch.
|
Looks that spdlog clash badly with ASIO. ASIO have a higher priority over spdlog, so would be necessary try to fix spdlog or replace it.
List of requisites that should have a logger for us :
The text was updated successfully, but these errors were encountered: