Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report for trillium-proxy: Compilation fails with --no-default-features #587

Closed
divergentdave opened this issue Mar 21, 2024 · 1 comment · Fixed by #589
Closed

Bug report for trillium-proxy: Compilation fails with --no-default-features #587

divergentdave opened this issue Mar 21, 2024 · 1 comment · Fixed by #589
Labels
bug Something isn't working

Comments

@divergentdave
Copy link
Contributor

Describe the bug
trillium-proxy cannot be built without the upstream-connection-counting feature enabled.

To Reproduce
cargo check -p trillium-proxy --no-default-features

error[E0432]: unresolved import `trillium_server_common`
 --> proxy/src/forward_proxy_connect.rs:6:5
  |
6 | use trillium_server_common::{Connector, ObjectSafeConnector};
  |     ^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `trillium_server_common`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `trillium-proxy` (lib) due to 1 previous error

Expected behavior
Successful compilation

@divergentdave divergentdave added the bug Something isn't working label Mar 21, 2024
jbr added a commit that referenced this issue Mar 22, 2024
without this, the crate did not build with --no-default-features
closes #587
jbr added a commit that referenced this issue Mar 22, 2024
without this, the crate did not build with --no-default-features
closes #587
@jbr jbr closed this as completed in #589 Mar 22, 2024
jbr added a commit that referenced this issue Mar 22, 2024
without this, the crate did not build with --no-default-features
closes #587
@jbr
Copy link
Contributor

jbr commented Mar 22, 2024

Thanks for reporting! Fix released as trillium-proxy@0.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants