Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http patch bugfix: make unknown header names case insensitive #312

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 10, 2023

closes #311

also relaxes some [Headers] lifetime requirements, closing #310

@jbr jbr force-pushed the headername-case-insensitivity branch from 2c2ce28 to 43fb560 Compare April 10, 2023 21:39
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #312 (43fb560) into main (5a52f44) will increase coverage by 0.26%.
The diff coverage is 58.10%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   42.31%   42.58%   +0.26%     
==========================================
  Files         139      141       +2     
  Lines        5494     5507      +13     
==========================================
+ Hits         2325     2345      +20     
+ Misses       3169     3162       -7     
Impacted Files Coverage Δ
http/src/headers/header_value.rs 39.62% <ø> (ø)
http/src/headers/unknown_header_name.rs 47.36% <47.36%> (ø)
http/src/headers/header_name.rs 48.57% <48.57%> (ø)
http/src/headers/known_header_name.rs 11.68% <50.00%> (ø)
http/src/headers.rs 67.40% <92.85%> (+3.49%) ⬆️
http/src/headers/header_values.rs 57.77% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jbr jbr merged commit 764dc0e into main Apr 10, 2023
@jbr jbr deleted the headername-case-insensitivity branch April 10, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report for trillium: Headers::get_values is case-sensitive for unknown header names
1 participant