Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Contao Manager Plugin #4

Merged
merged 1 commit into from Mar 6, 2019
Merged

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Mar 6, 2019

  • The setLoadAfter array had ContaoCoreBundle::class - however, there was no use Contao\CoreBundle\ContaoCoreBundle; statement and thus it never worked.
  • Instead of 'comments' it should use \Contao\CommentsBundle\ContaoCommentsBundle::class.
  • The dependency to the newsletter bundle was missing.

@fiedsch
Copy link

fiedsch commented Mar 6, 2019

Wouldn't that imply that ContaoCommentsBundleand ContaoNewsletterBundlehave to be installed in order to get the TrilobitFormvalidationBundle loaded after them?

@trilobit-gmbh trilobit-gmbh self-requested a review March 6, 2019 11:34
@trilobit-gmbh trilobit-gmbh merged commit dda8187 into trilobit-gmbh:master Mar 6, 2019
@trilobit-gmbh
Copy link
Owner

Thank you for your attention and the pull request!

Peter

@fritzmg
Copy link
Contributor Author

fritzmg commented Mar 6, 2019

Wouldn't that imply that ContaoCommentsBundleand ContaoNewsletterBundlehave to be installed in order to get the TrilobitFormvalidationBundle loaded after them?

No, neither the use statements nor the ::class calls will cause any problems, if those classes are not present. Otherwise it would have already been a Problem, since the class

Trilobit\FormvalidationBundle\ContaoManager\ContaoCorebundle

doesn't actually exist ;)

@fritzmg fritzmg deleted the patch-1 branch March 6, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants