Add select_db as an alias for change_db
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`select_db` is the method name in the mysql2 gem and also seems to be the preferred nomenclature in the [mysql documentation](https://dev.mysql.com/doc/c-api/5.7/en/mysql-select-db.html). AFAICT, both use `COM_INIT_DB` under the hood. Having `select_db` as an alias will make it easier to transition from `mysql2` -> `trilogy` (even if this likely isn't used _that_ frequently) There seems to be no noticable performance penalty for using the alias, at least with Ruby 3.2.2: ``` ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22] Warming up -------------------------------------- native 1.260M i/100ms alias 1.265M i/100ms Calculating ------------------------------------- native 12.583M (± 1.0%) i/s - 63.025M in 5.009167s alias 12.538M (± 1.0%) i/s - 63.257M in 5.045579s Comparison: native: 12583154.1 i/s alias: 12538412.7 i/s - same-ish: difference falls within error ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select_dbis the method name in the mysql2 gem and also seems to be the preferred nomenclature in the mysql documentation.AFAICT, both use
COM_INIT_DBunder the hood. Havingselect_dbas an alias will make it easier to transition frommysql2->trilogy(even if this likely isn't used that frequently)There seems to be no noticable performance penalty for using the alias, at least with Ruby 3.2.2: