Merge pull request #363 from trimble-oss/339-unable-do-animation-for-…

…popup-page Unable do animation for popup page #339
trimble-oss · Apr 1, 2024 · 6095c0b · 6095c0b
2 parents 416614e + 487f149
commit 6095c0b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/DemoApp/DemoApp/Views/PopupSamples/SampleCustomPopup.xaml.cs b/DemoApp/DemoApp/Views/PopupSamples/SampleCustomPopup.xaml.cs
@@ -1,5 +1,7 @@
 using DemoApp.ViewModels;
 using Trimble.Modus.Components;
+using Trimble.Modus.Components.Popup.Animations;
+using Trimble.Modus.Components.Popup.Enums;
 
 namespace DemoApp.Views.PopupSamples;
 
@@ -10,5 +12,6 @@ public SampleCustomPopup()
     {
         InitializeComponent();
         BindingContext = _viewModel;
+        Animation = new MoveAnimation() { PositionIn = MoveAnimationOptions.Left, PositionOut = MoveAnimationOptions.Left, DurationIn = 500, DurationOut = 500 };
     }
 }
diff --git a/Trimble.Modus.Components/Controls/Popup/Animations/Base/BaseAnimation.cs b/Trimble.Modus.Components/Controls/Popup/Animations/Base/BaseAnimation.cs
@@ -52,7 +52,7 @@ public interface IPopupAnimation
     Task Appearing(View content, PopupPage page);
     Task Disappearing(View content, PopupPage page);
 }
-internal abstract class BaseAnimation : IPopupAnimation
+public abstract class BaseAnimation : IPopupAnimation
 {
     private const uint DefaultDuration = 200;
 

diff --git a/Trimble.Modus.Components/Controls/Popup/Animations/Base/FadeBackgroundAnimation.cs b/Trimble.Modus.Components/Controls/Popup/Animations/Base/FadeBackgroundAnimation.cs
@@ -2,7 +2,7 @@
 
 namespace Trimble.Modus.Components.Popup.Animations.Base;
 
-internal abstract class FadeBackgroundAnimation : BaseAnimation
+public abstract class FadeBackgroundAnimation : BaseAnimation
 {
     private Color? _backgroundColor;
 

diff --git a/Trimble.Modus.Components/Controls/Popup/Animations/MoveAnimation.cs b/Trimble.Modus.Components/Controls/Popup/Animations/MoveAnimation.cs
@@ -5,7 +5,7 @@
 
 namespace Trimble.Modus.Components.Popup.Animations;
 
-internal class MoveAnimation : FadeBackgroundAnimation
+public class MoveAnimation : FadeBackgroundAnimation
 {
     private double _defaultTranslationX;
     private double _defaultTranslationY;

diff --git a/Trimble.Modus.Components/Controls/Popup/Enums/MoveAnimationOptions.cs b/Trimble.Modus.Components/Controls/Popup/Enums/MoveAnimationOptions.cs
@@ -1,6 +1,6 @@
 namespace Trimble.Modus.Components.Popup.Enums;
 
-internal enum MoveAnimationOptions
+public enum MoveAnimationOptions
 {
     Center,
     Left,

diff --git a/Trimble.Modus.Components/Controls/Popup/Pages/PopupPage.cs b/Trimble.Modus.Components/Controls/Popup/Pages/PopupPage.cs
@@ -40,7 +40,7 @@ public bool HasSystemPadding
 
     public static readonly BindableProperty AnimationProperty = BindableProperty.Create(nameof(Animation), typeof(IPopupAnimation), typeof(PopupPage), new ScaleAnimation());
 
-    internal IPopupAnimation Animation
+    public IPopupAnimation Animation
     {
         get => (IPopupAnimation)GetValue(AnimationProperty);
         set => SetValue(AnimationProperty, value);