Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Multi select chips render issue #2681

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Jul 8, 2024

Description

References

  1. Value Prop now accepts both 
    single-select-type = string
    multiple-select-type = string[]

  2. The default value can be assigned for multi-select, provided the value is an array.
    e.g., ['Apple', 'Orange']

  3. valueChange event emitter type changed to string | string[].

Fixes #2529 #2528

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@prashanthr6383 prashanthr6383 marked this pull request as draft July 8, 2024 10:56
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit d4218d3
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66965ba6087c8a00087132d8
😎 Deploy Preview https://deploy-preview-2681--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 changed the title 2529 - autocomplete string to chip conversion on initilization Autocomplete : Multi select render issue Jul 8, 2024
@prashanthr6383 prashanthr6383 changed the title Autocomplete : Multi select render issue Autocomplete: Multi select chips render issue Jul 8, 2024
@prashanthr6383 prashanthr6383 marked this pull request as ready for review July 16, 2024 11:45
@prashanthr6383
Copy link
Collaborator Author

@cjwinsor I have added the test cases now and it is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-select render issue in autocomplete
1 participant