fix(chips): Move trailing icon to isolated gridcell (#2097)

closes #2096
trimox · Feb 16, 2020 · 4f3ac9d · 4f3ac9d
1 parent 4d50928
commit 4f3ac9d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/chips/chip-set.ts b/packages/chips/chip-set.ts
@@ -216,6 +216,7 @@ export class MdcChipSet extends MDCComponent<MDCChipSetFoundation>
 
     this._dropSubscriptions();
     this._chipRemovalSubscription?.unsubscribe();
+    this._foundation?.destroy();
   }
 
   // Implemented as part of ControlValueAccessor.

diff --git a/packages/chips/chip.ts b/packages/chips/chip.ts
@@ -101,7 +101,11 @@ export class MdcChipCheckmark {
       <mdc-chip-text *ngIf="label">{{label}}</mdc-chip-text>
       <ng-content></ng-content>
     </mdc-chip-primary-action>
-  </span>`,
+  </span>
+  <span role="gridcell" *ngIf="!!trailingIcon">
+    <ng-content select="mdc-chip-icon[trailing]"></ng-content>
+  </span>
+  `,
   encapsulation: ViewEncapsulation.None,
   changeDetection: ChangeDetectionStrategy.OnPush,
   providers: [MdcRipple]