Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Scrolling Temp drawer ripple problem #440

Closed
TeodorKolev opened this issue Dec 8, 2017 · 11 comments
Closed

Scrolling Temp drawer ripple problem #440

TeodorKolev opened this issue Dec 8, 2017 · 11 comments
Assignees
Labels

Comments

@TeodorKolev
Copy link

TeodorKolev commented Dec 8, 2017

What Angular MDC version are you using?

0.6.2

What browser(s) is this bug affecting?

all

What OS are you using?

Ubuntu 17.04

What are the steps to reproduce the bug?

Go to mobile view and start scroll temp drawer.

What is the expected behavior?

Items background should be restored on mouseup

What is the actual behavior?

background stays and all touched items becomes grey, or whatever color is set

Any other information you believe would be useful?

@TeodorKolev TeodorKolev changed the title Scrolling Temp drawer ripple problme Scrolling Temp drawer ripple problem Dec 8, 2017
@trimox
Copy link
Owner

trimox commented Dec 9, 2017

Yeah, problem is upstream in material-components-web. Before I implement a workaround, lemme see if the MDC team is working on it.

@trimox
Copy link
Owner

trimox commented Dec 13, 2017

I stumbled on the bug. Working on a fix

@trimox trimox added bug and removed research labels Dec 13, 2017
@trimox trimox self-assigned this Dec 13, 2017
@trimox trimox added this to the Milestone v0.6.5 milestone Dec 13, 2017
trimox added a commit that referenced this issue Dec 13, 2017
@trimox
Copy link
Owner

trimox commented Dec 13, 2017

Resolved in #457

@TeodorKolev
Copy link
Author

@trimox When we be able to see the fix?

@trimox
Copy link
Owner

trimox commented Dec 13, 2017

@TeodorKolev Testing is going well, planning an update in a couple hours.

@trimox
Copy link
Owner

trimox commented Dec 14, 2017

Reopening. Issue originating from mdc-list-item.

@trimox trimox reopened this Dec 14, 2017
@TeodorKolev
Copy link
Author

@trimox thank you

@trimox
Copy link
Owner

trimox commented Dec 15, 2017

@TeodorKolev No prob. Updating to latest material-components-web today, and it'll be the next issue I resolve.

@trimox
Copy link
Owner

trimox commented Dec 19, 2017

Good news. Upstream just opened a PR to resolve. material-components/material-components-web#1800

@TeodorKolev
Copy link
Author

Is it fixed already, should I install a new version or something?

@trimox
Copy link
Owner

trimox commented Dec 19, 2017

Waiting for material-components/material-components-web#1800 to be merged into material-components-web master branch. I plan to incorporate the change quickly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants