Option for disabling log rotation?

[soemo]

Hi,

is there a option in the config to stop the log rotation?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[kares]

sorry not really yet (just like in TC), but there will be, somewhere along the next release(s), I did not want to add a separate option for that as I'd like a logging configuration to be fully customizable from trinidad.yml. for now you need to use 1.3 or change it and use a custom version https://github.com/trinidad/trinidad/blob/master/lib/trinidad/logging.rb#L79

[tolsen]

Hi @kares . I've turned off logging here in my own custom version: https://github.com/tolsen/trinidad/blob/jux/lib/trinidad/logging.rb#L79

But now I am not seeing any requests being logged. If I turn rotation back on, I see requests being logged again. I don't know if it's relevant but I am setting :log_dir. Just in case, I checked the default location for the logs and I don't see anything there either

Any idea what's happening?

[kares]

@tolsen there was a bug 5fb7e0a

I'm sorry this feature is coming a bit late since there were quite a few things planned about the logging configuration in my head - nevertheless, to get somewhere there's now unofficial support for configuring the file handler on master :

  logging:
    file:
      rotate: false
      prefix: "myapp"
      suffix: .log
      directory: /opt/myapp/custom-log-dir
      buffer_size: 4096

this should work with the next release 1.4.4 but do not take my word for it (might slightly change) ...

[tolsen]

Thanks again Karol! :-) I'll watch out for any changes. Btw, it appears that the correct key for specifying the directory is :dir

[mohamedhafez]

So does the configuration shown above work in 1.4.4 to turn off log rotation?

[kares]

yes, it's just not officially supported yet ... since it should generically handle all possible JUL configurations

[soemo]

Hi, the inofficial configuration works for me.

logging:
    file:
      rotate: false

When is this feature official documented? At this point we can close this issue.