Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bryntroll, the Bone Arbiter - understated proc #4954

Closed
SignFinder opened this issue Jan 25, 2012 · 24 comments
Closed

[BUG] Bryntroll, the Bone Arbiter - understated proc #4954

SignFinder opened this issue Jan 25, 2012 · 24 comments

Comments

@SignFinder
Copy link
Contributor

TC b67b75c
TDb45+updates

This spell http://www.wowhead.com/spell=71839 from http://www.wowhead.com/item=50709 procs very rarely, once in ~ 4 minutes.
Here very rarely, once in ~ 4 minutes in comments referred to two procs per minute.

Find more specific information I could not.
But in the present state of affairs, this ax is simply useless.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Midnights
Copy link

Well, 2ppm is right, try to find the spell in spell_proc_event or smth

@SignFinder
Copy link
Contributor Author

@Midnights in spell_proc_event not have entries for spell 71839

@3kids
Copy link

3kids commented Jan 26, 2012

Check the item_template spell entrys. The proc is handled there

@SignFinder
Copy link
Contributor Author

UPDATE item_template SET spellppmRate_1 = '2' WHERE item_template.entry =50709;
not fix problem

PS
UPDATE testtdb45.item_template SET spellppmRate_1 = '0',
spellcooldown_1 =30000 WHERE item_template.entry =50709
not fix problem :-(

@Midnights
Copy link

spellcooldown is not right, the spell should have a ppm rate of 2, not a cooldown of 30 secs
its NOT the same
and how do you test it? just with autohits or with abilities?

Edit: why are you using the heroic version of the axe?? is the normal one working?

@SignFinder
Copy link
Contributor Author

@Midnights - i test it only autohit with maneken without abilities.
Normal version - i not tested.

@Midnights
Copy link

Then test the normal version first please
and with how many autohits did you test it?

@SignFinder
Copy link
Contributor Author

test for normal version http://www.wowhead.com/item=50415

test only with autohits - 6 minutes (clean TC, clean TDB)

PROC TIME - INTERVAL
PROC1 00:00:45.085 - 00:00:45.085
PROC2 00:01:29.805 - 00:00:44.720
PROC3 00:01:36.806 - 00:00:07.001
PROC4 00:02:00.532 - 00:00:23.726
PROC5 00:02:38.281 - 00:00:37.749
PROC6 00:02:51.986 - 00:00:13.705
PROC7 00:02:58.651 - 00:00:06.665
PROC8 00:04:13.634 - 00:01:14.983
PROC9 00:05:47.522 - 00:01:33.888
PROC10 00:05:50.994 - 00:00:03.472
PROC11 00:05:54.440 - 00:00:03.446

"spellcooldown_1" for normal item in TDB=1000, for heroic=-1 - its normal?

@SignFinder
Copy link
Contributor Author

test for heroicl version http://www.wowhead.com/item=50709
test only with autohits - 6 minutes (clean TC, clean TDB)

PROC TIME - INTERVAL
PROC1 00:00:24.273 - 00:00:24.273
PROC2 00:01:43.294 - 00:01:19.021
PROC3 00:02:38.177 - 00:00:54.883
PROC4 00:04:35.204 - 00:01:57.027
PROC5 00:05:36.478 - 00:01:01.274

@SignFinder
Copy link
Contributor Author

test for heroic version http://www.wowhead.com/item=50709
test only with autohits - 6 minutes (clean TC, clean TDB+spellcooldown_1=1000)

PROC1 00:01:32.580 - 00:01:32.580
PROC2 00:02:17.244 - 00:00:44.664
PROC3 00:02:27.538 - 00:00:10.294
PROC4 00:04:30.989 - 00:02:03.451
PROC5 00:05:19.263 - 00:00:48.274

@Midnights
Copy link

There should be no cooldown at all on this spell
is there no difference between normal and heroic version except spellcooldown_1 ?

@SignFinder
Copy link
Contributor Author

Yes-no differences except spellcoooldown_1 - only different stat values

@Star-lion
Copy link
Contributor

UPDATE `item_template` SET `spellcooldown_1`=1000 WHERE `entry`=50709;

try that

@ghost ghost assigned ZxBiohazardZx and Subv Nov 13, 2012
@P-Kito
Copy link
Contributor

P-Kito commented Aug 28, 2013

push still bugged

@untaught
Copy link
Contributor

UPDATE `item_template` SET `spellcooldown_1`=-1 WHERE `entry`=50415; 
UPDATE `item_template` SET `spellppmRate_1`=2 WHERE `entry` IN (50415,50709);

@P-Kito
Copy link
Contributor

P-Kito commented Sep 11, 2013

It still triggers on AP, SP and it does crit

@Aokromes
Copy link
Member

Aokromes commented Nov 3, 2013

untaught 's fix work?

@Aokromes
Copy link
Member

This can be pushed?

@untaught
Copy link
Contributor

Works for me.

@L30m4nc3r
Copy link

@untaught yea its work.
on 1 problems. (heal +1 | drain life spell damage 2100+)
wowscrnshot_031714_105827

@untaught
Copy link
Contributor

Okay, this dummy has 1 HP. How you want to get more from it?
Proc works with sql fix I put above and healing spell is fine too. Try on target with more hp for example:
http://i.imgur.com/ekQFv8h.jpg
See the combat log. 😉

@L30m4nc3r
Copy link

ahahh Sorry! my bad!
Work fix. thanks!

@P-Kito
Copy link
Contributor

P-Kito commented Mar 17, 2014

It still scales with AP and SP

@untaught
Copy link
Contributor

I don't see any scale calculations but you can try:

UPDATE `item_template` SET `spellcooldown_1`=-1 WHERE `entry`=50415; 
UPDATE `item_template` SET `spellppmRate_1`=2 WHERE `entry` IN (50415,50709);
DELETE FROM `spell_bonus_data` WHERE `entry` IN (71839,71838);
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `ap_dot_bonus`, `comments`) VALUES
(71839,0,0,0,0,'Drain Life'),
(71838,0,0,0,0,'Drain Life');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests