Update to ns6 #129
Merged
Update to ns6 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @triniwiz is it possible for you to release this ? :P i need to ship ittttt ;) |
charsleysa
reviewed
Jul 30, 2019
| @@ -0,0 +1,5 @@ | |||
| dependencies { | |||
| def androidxVersion = project.hasProperty("androidxVersion") ? project.androidxVersion : "1.0.0" | |||
There was a problem hiding this comment.
project property for androidx appcompat is called androidXAppCompat not androidxVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apart from @shiv19 work, i added android x gradle dependency also updated js dependencies on all projects, all on them work on both platforms and with the three frameworks and core ;)