Add support for NativeScript 6, and playback inside modals on Android #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @triniwiz,
I was trying to show a video inside a modal in a NativeScript 6 app and found that it didn't work for two reasons:
com.google.android.youtube.player.YouTubePlayerFragment
extendsandroid.app.Fragment
directly, which means it's not compatible with AndroidX (and thus NativeScript 6). However,com.google.android.youtube.player.YouTubePlayerSupportFragment
extendsandroid.support.v4.app.Fragment
which is.In case you accept this PR, please also publish a new version to npm because I'm sure more N6-using folks will encounter this issue. A major version bump would be a good idea because I'm not 100% sure it's backward compatible (didn't test it with N5).
Cheers,
Eddy