Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p_load_gh vs. p_load_current_gh #87

Open
Dasonk opened this issue Mar 3, 2017 · 0 comments
Open

p_load_gh vs. p_load_current_gh #87

Dasonk opened this issue Mar 3, 2017 · 0 comments

Comments

@Dasonk
Copy link
Collaborator

Dasonk commented Mar 3, 2017

I basically wasn't dealing with pacman stuff when the github functionality was added. I'm back now and looking over some of the code. The design choice in making two functions p_load_gh and p_load_current_gh seems odd to me. Typically we would set a parameter in the p_load_gh to indicate if we want the current most version from github instead of having a separate function.

Is there a reason for this choice? Should we change it or leave it as it is?

Side note: At some point I think we should map out how we want things to work. Originally we just had the initial aim to be installing/loading from CRAN but we've obviously expanded that scope. I think we should have a discussion about what we want our code to do in various situations when dealing with repositories other than CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant