You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I basically wasn't dealing with pacman stuff when the github functionality was added. I'm back now and looking over some of the code. The design choice in making two functions p_load_gh and p_load_current_gh seems odd to me. Typically we would set a parameter in the p_load_gh to indicate if we want the current most version from github instead of having a separate function.
Is there a reason for this choice? Should we change it or leave it as it is?
Side note: At some point I think we should map out how we want things to work. Originally we just had the initial aim to be installing/loading from CRAN but we've obviously expanded that scope. I think we should have a discussion about what we want our code to do in various situations when dealing with repositories other than CRAN.
The text was updated successfully, but these errors were encountered:
I basically wasn't dealing with pacman stuff when the github functionality was added. I'm back now and looking over some of the code. The design choice in making two functions
p_load_gh
andp_load_current_gh
seems odd to me. Typically we would set a parameter in thep_load_gh
to indicate if we want the current most version from github instead of having a separate function.Is there a reason for this choice? Should we change it or leave it as it is?
Side note: At some point I think we should map out how we want things to work. Originally we just had the initial aim to be installing/loading from CRAN but we've obviously expanded that scope. I think we should have a discussion about what we want our code to do in various situations when dealing with repositories other than CRAN.
The text was updated successfully, but these errors were encountered: