Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated CRANextra repo #129

Merged
merged 2 commits into from May 15, 2020
Merged

Remove outdated CRANextra repo #129

merged 2 commits into from May 15, 2020

Conversation

mmcgowan13
Copy link
Contributor

It appears that "http://www.stats.ox.ac.uk/pub/RWin" has not been updated for several years, so this can cause issues for Windows users using newer versions of R.

It appears that "http://www.stats.ox.ac.uk/pub/RWin" has not been updated for several years, so this can cause issues for Windows users using newer versions of R.
@coveralls
Copy link

coveralls commented May 15, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling d328a24 on mmcgowan13:patch-1 into fc09ccd on trinker:master.

@Dasonk
Copy link
Collaborator

Dasonk commented May 15, 2020

Good call. Can you add yourself as a contributor in the description file and I'll accept the PR

@mmcgowan13
Copy link
Contributor Author

@Dasonk I'm not sure it's necessary that I count as a contributor for such a trivial change, but I can update the description file if you like.

I only deleted some code, so I'm not sure I really count as a contributor.
@Dasonk Dasonk merged commit ace0936 into trinker:master May 15, 2020
@Dasonk
Copy link
Collaborator

Dasonk commented May 15, 2020

The change probably wouldn't have happened without you figuring out it needed to be done, tracking down what needed to be changed, and submitting the PR. That's more than enough to warrant contributor in my book. Thanks for the contribution.

@mmcgowan13 mmcgowan13 deleted the patch-1 branch May 15, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants