Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to jmx metrics #140

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/trino/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.19.0
version: 0.20.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
7 changes: 7 additions & 0 deletions charts/trino/templates/configmap-coordinator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ data:
-XX:+UnlockDiagnosticVMOptions
# Reduce starvation of threads by GClocker, recommend to set about the number of cpu cores (JDK-8192647)
-XX:GCLockerRetryAllocationCount=32
{{- if .Values.jmx.enabled }}
-Dcom.sun.management.jmxremote.rmi.port={{ .Values.jmx.serverPort }}
{{- end }}
{{- range $configValue := .Values.coordinator.additionalJVMConfig }}
{{ $configValue }}
{{- end }}
Expand Down Expand Up @@ -67,6 +70,10 @@ data:
http-server.https.port={{ .Values.server.config.https.port }}
http-server.https.keystore.path={{ .Values.server.config.https.keystore.path }}
{{- end }}
{{- if .Values.jmx.enabled }}
jmx.rmiregistry.port={{ .Values.jmx.registryPort }}
jmx.rmiserver.port={{ .Values.jmx.serverPort }}
{{- end }}
{{ .Values.server.coordinatorExtraConfig | indent 4 }}

{{- if .Values.accessControl }}{{- if eq .Values.accessControl.type "configmap" }}
Expand Down
8 changes: 8 additions & 0 deletions charts/trino/templates/deployment-coordinator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,14 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
{{-if .Values.jmx.enabled }}
- name: jmx-registry
containerPort: {{ .Values.jmx.registryPort }}
protocol: TCP
- name: jmx-server
containerPort: {{ .Values.jmx.serverPort }}
protocol: TCP
{{- end }}
{{- range $key, $value := .Values.coordinator.additionalExposedPorts }}
- name: {{ $value.name }}
containerPort: {{ $value.port }}
Expand Down
10 changes: 10 additions & 0 deletions charts/trino/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@ spec:
targetPort: http
protocol: TCP
name: http
{{- if .Values.jmx.enabled }}
- port: {{ .Values.jmx.registryPort }}
targetPort: jmx-registry
protocol: TCP
name: jmx-registry
- port: {{ .Values.jmx.serverPort }}
targetPort: jmx-server
protocol: TCP
name: jmx-server
{{- end }}
{{- range $key, $value := .Values.coordinator.additionalExposedPorts }}
- port: {{ $value.servicePort }}
name: {{ $value.name }}
Expand Down
4 changes: 4 additions & 0 deletions charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ imagePullSecrets:
- name: registry-credentials

server:
jmx:
enabled: true
registryPort: 9080
serverPort: 9081
workers: 2
node:
environment: production
Expand Down