Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accumulo to 3.0.0 #186

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update accumulo to 3.0.0 #186

merged 1 commit into from
Feb 15, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 15, 2024 •
edited
Loading

Verified locally with the updated connector. All tests are passing.

@cla-bot cla-bot bot added the cla-signed label Feb 15, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

Funny:

0.535 ERROR: cannot verify archive.apache.org's certificate, issued by ‘/C=US/O=Let's Encrypt/CN=R3’:
0.535   Issued certificate has expired.
0.535 To connect to archive.apache.org insecurely, use `--no-check-certificate'.

hashhar
hashhar reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd appreciate a second set of eyes though.

@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

I can post a PR in Trino to test this :)

@wendigo wendigo mentioned this pull request Feb 15, 2024
Merged
@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

@hashhar trinodb/trino#20720 works

@wendigo wendigo force-pushed the serafin/accumulo-3.0 branch 2 times, most recently from cca03a6 to e3f46a4 Compare February 15, 2024 12:21
hashhar
hashhar previously approved these changes Feb 15, 2024
View reviewed changes
@hashhar hashhar dismissed their stale review February 15, 2024 13:48

no-check-certs is not good.

@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

@hashhar the master is broken so what's the alternative?

@wendigo wendigo requested a review from hashhar February 15, 2024 14:23
@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

@hashhar updating base image did the trick. PTAL again :)

nineinchnick
nineinchnick approved these changes Feb 15, 2024
View reviewed changes
testing/accumulo/Dockerfile Outdated Show resolved Hide resolved
testing/accumulo/Dockerfile Show resolved Hide resolved
@wendigo
Update accumulo to 3.0.0
d47aee3 
Switch to centos7-oj11 image as accumulo requires JDK 11.
@wendigo wendigo merged commit 365d031 into master Feb 15, 2024
24 of 25 checks passed
@wendigo wendigo deleted the serafin/accumulo-3.0 branch February 15, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nineinchnick nineinchnick nineinchnick approved these changes

@hashhar hashhar hashhar approved these changes

@electrum electrum Awaiting requested review from electrum

@findepi findepi Awaiting requested review from findepi

@losipiuk losipiuk Awaiting requested review from losipiuk

@ebyhr ebyhr Awaiting requested review from ebyhr

@adamjshook adamjshook Awaiting requested review from adamjshook

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
3 participants
@wendigo @nineinchnick @hashhar