Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check certificates for archive.apache.org #187

Closed
wants to merge 1 commit into from
Closed

Do not check certificates for archive.apache.org #187

wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 15, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 15, 2024
findepi
findepi reviewed Feb 15, 2024
View reviewed changes
testing/phoenix5/Dockerfile
@@ -32,7 +32,7 @@ ARG PHOENIX_BINARY_PATH=$BASE_URL/phoenix/phoenix-$PHOENIX_VERSION/phoenix-hbase
RUN mkdir -p $IMAGE_ROOT_INSTALL

# Download ZooKeeper
RUN wget --quiet $ZOOKEEPER_BINARY_PATH && \
RUN wget --no-check-certificate -nv $ZOOKEEPER_BINARY_PATH && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-check-certificate should be code-documented i guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative: #188

@findepi
Copy link
Member

findepi commented Feb 15, 2024

this sounds wrong. Why do we need this?

@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

@findepi master doesn't build anymore

@wendigo
Copy link
Contributor Author

wendigo commented Feb 15, 2024

@findepi

 > [2/6] RUN set -xeu;     wget -nv "https://archive.apache.org/dist/spark/spark-3.4.2/spark-3.4.2-bin-hadoop3.tgz";     tar -xf spark-3.4.2-bin-hadoop3.tgz;     rm spark-3.4.2-bin-hadoop3.tgz;     ln -sn /spark-3.4.2-bin-hadoop3 /spark:
0.147 + wget -nv https://archive.apache.org/dist/spark/spark-3.4.2/spark-3.4.2-bin-hadoop3.tgz
0.571 ERROR: cannot verify archive.apache.org's certificate, issued by ‘/C=US/O=Let's Encrypt/CN=R3’:
0.571   Issued certificate has expired.
0.571 To connect to archive.apache.org insecurely, use `--no-check-certificate'.

@wendigo wendigo closed this Feb 15, 2024
@wendigo wendigo deleted the serafin/archive.apache branch February 15, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi left review comments

@losipiuk losipiuk Awaiting requested review from losipiuk

@ebyhr ebyhr Awaiting requested review from ebyhr

@hashhar hashhar Awaiting requested review from hashhar

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
2 participants
@wendigo @findepi