Align before/after with class hierarchy #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "override" from `TestClassOverrideAdditionalAnnotatedMethod` since there are no overrides involved. Use different constants for testing overrides and for testing additional methods.
Order `@BeforeMethodWithContext` according to class hierarchy: parent class first; like in other test frameworks. This allows a subclass to leverage parent class state. Order `@AfterMethodWithContext` in a reversed order.
|
In Trino, this will allow child classes not to invoke |
losipiuk
reviewed
Feb 12, 2024
| @@ -61,7 +61,9 @@ class TestInitializationListenerTest | |||
| static final String BEFORE_METHOD = "beforeMethod" | |||
| static final String AFTER_METHOD = "afterMethod" | |||
| public static final String BEFORE_METHOD_OVERRIDE = "beforeMethodOverride" | |||
| public static final String BEFORE_METHOD_ADDITIONAL = "beforeMethodAdditional" | |||
There was a problem hiding this comment.
why are you keeping beforeMethodOverride? I think I do not follow
There was a problem hiding this comment.
it's used in separate test case, with actual overrides
losipiuk
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order
@BeforeMethodWithContextaccording to class hierarchy: parentclass first; like in other test frameworks. This allows a subclass to
leverage parent class state.
Order
@AfterMethodWithContextin a reversed order.