Get cluster health from v1/info #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Feb 24, 2024
...-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsCoordinatorInfoMonitor.java
Outdated
Show resolved
Hide resolved
...-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsCoordinatorInfoMonitor.java
Outdated
Show resolved
Hide resolved
...-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsCoordinatorInfoMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/config/ClusterStatsMonitorType.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/clustermonitor/TestClusterStatsMonitor.java
Outdated
Show resolved
Hide resolved
...-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsCoordinatorInfoMonitor.java
Outdated
Show resolved
Hide resolved
...-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsCoordinatorInfoMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/module/ClusterStatsMonitorModule.java
Outdated
Show resolved
Hide resolved
|
Can we deprecate UI API based monitoring? |
I think ultimately yes .. we still have to chat to the upstream Trino project itself about maybe having a better REST endpoint for cluster health / readiness with info such as attached worker number. I still have to even initiate that discussion |
willmostly
force-pushed
the
will/status_only_healthcheck
branch
from
836fec5
to
14b18b6
Compare
willmostly
force-pushed
the
will/status_only_healthcheck
branch
from
14b18b6
to
4fad665
Compare
ebyhr
reviewed
Feb 27, 2024
gateway-ha/src/test/java/io/trino/gateway/ha/clustermonitor/TestClusterStatsMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/status_only_healthcheck
branch
from
4fad665
to
34bc9e0
Compare
andythsu
reviewed
Feb 28, 2024
| @@ -97,6 +97,22 @@ | |||
| </exclusions> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>io.airlift</groupId> | |||
| <artifactId>http-client</artifactId> | |||
There was a problem hiding this comment.
are we potentially removing OkHttp to use this in the future? Or we will keep both in the repo?
There was a problem hiding this comment.
I think we should be able to eliminate the runtime dependency on OkHttp. It is used in several tests, but the gateway itself only uses it in ClusterStatsApiMonitor. We can probably switch over for tests too, just a bit more work.
ebyhr
reviewed
Feb 29, 2024
gateway-ha/src/test/java/io/trino/gateway/ha/clustermonitor/TestClusterStatsMonitor.java
Show resolved
Hide resolved
ebyhr
reviewed
Feb 29, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Show resolved
Hide resolved
willmostly
force-pushed
the
will/status_only_healthcheck
branch
2 times, most recently
from
a9a0fb5
to
80f3e1c
Compare
ebyhr
reviewed
Mar 1, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/status_only_healthcheck
branch
3 times, most recently
from
6b66c61
to
0bb38f8
Compare
ebyhr
approved these changes
Mar 4, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsInfoApiMonitor.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/status_only_healthcheck
branch
from
0bb38f8
to
0aa7332
Compare
|
Just quick note.. this is definitely the right approach .. we might have it even more useful from the Trino side soon. |
Chaho12
approved these changes
Mar 6, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ServerInfo.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/status_only_healthcheck
branch
from
0aa7332
to
388172f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lightweight health check against the coordinator's
v1/info. A cluster is set to healthy as long as the coordinator returns a 200 response and is not in the process of starting.v1/infodoes not require authentication, which addresses the concerns raised in