Replace WireMock with okhttp3:mockwebserver #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneonestar
force-pushed
the
star/okhttp3_mock
branch
from
d096403
to
cbdf595
Compare
wendigo
approved these changes
Mar 27, 2024
|
VERY NICE! |
This was referenced Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #41
Replace WireMock with okhttp3:mockwebserver.
Trino is also using
okhttp3:mockwebserverfor testing.WireMock depends on jetty 11 which is incompatible with Airlift (jetty 12 & EE 10).
TODO
Update okhttp3 to the latest version (
3.14.9->4.12.0).Side effect:
New version of okhttp3 won't send Authorization header after a redirect. (See: trinodb/trino#21026)
This might break credentials-based authentication if anyone is using:
Trino-gateway -> (some proxy with redirect mode) -> Trino.Needs to override this behavior and always send Authorization header.
ConnectHandler and proxy ServletHolder might not be affect => need to verify.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.