Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add airlift stats #311

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add airlift stats #311

merged 1 commit into from
Apr 10, 2024

Conversation

oneonestar
Copy link
Member

Description

Part of #41.

Abstract the stats counting using ProxyHandlerStats.
This is similar to the implementation inTrino, see: CallStats.java

Add airlift stats in parallel with io.dropwizard.metrics.
Can't remove io.dropwizard.metrics right now because we can't export airlift stats in REST API under Dropwizard.

After switch to Airlift, ProxyHandlerStats and CounterStat will stay.
com.codahale.metrics.Meter and Environment will be gone.

JMX JMX using RESTful API JMX Provider
Before this PR Dropwizard metric Dropwizard metric (localhost:9082/metrics) Dropwizard and MetricRegistry
After this PR Dropwizard metric + Airlift stats Dropwizard metric (localhost:9082/metrics) Dropwizard and MetricRegistry
After migration to Airlift Airlift stats Airlift stats (/v1/jmx) Airlift:jmx and Airlift:jmx-http

JMX can be accessed using RMI (by jconsole or jvisualvm).
Airlift stats (new):
image

Dropwizard metrics (existing):
image

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@ebyhr ebyhr merged commit 7efac67 into trinodb:main Apr 10, 2024
2 checks passed
@github-actions github-actions bot added this to the 8 milestone Apr 10, 2024
@oneonestar oneonestar deleted the star/airlift_stats branch April 13, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants