Add test for authorization #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneonestar
force-pushed
the
star/auth_test1
branch
from
b7965e9
to
3332729
Compare
ebyhr
approved these changes
Apr 16, 2024
| { | ||
| HaGatewayTestUtils.TestConfig testConfig = HaGatewayTestUtils.buildGatewayConfigAndSeedDb(routerPort, "auth/auth-test-config.yml"); | ||
| String[] args = {"server", testConfig.configFilePath()}; | ||
| HaGatewayLauncher.main(args); |
There was a problem hiding this comment.
Does this gateway service close soon after this test class finished on CI? Or will it keep running until the all test classes finish?
There was a problem hiding this comment.
A recent change set reuseForks to false should make each test class run in a separate JVM fork. I think each JVM will be teardown by JUnit after the test, thus release the resource.
trino-gateway/gateway-ha/pom.xml
Line 543 in 5efec71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for authorization.
This is a regression test for #310.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.