Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install and probe bugs #348

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

willmostly
Copy link
Contributor

Description

This fixes a nil pointer issue when Helm evaluates the deployment template before the secrets template creates trino-gateway-configuration. It also fixes an issue with the liveness and readiness probe templates.

Additional context and related issues

The nil pointer issue may result in an error message like

Error: template: trino-gateway/templates/deployment.yaml:20:71: executing "trino-gateway/templates/deployment.yaml" at <"trino-gateway-configuration">: nil pointer evaluating interface {}.resourceVersion

The templating issue results in a livenessProbe like:

livenessProbe:
            httpGet:
                path: /
                port: 9082
            initialDelaySeconds: .Values.livenessProbe.initialDelaySeconds
            periodSeconds: .Values.livenessProbe.periodSeconds
            failureThreshold: .Values.livenessProbe.failureThreshold
            timeoutSeconds: .Values.livenessProbe.timeoutSeconds

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Fix issue with Helm deployment when configuration secret not create
* Pass template values through to readiness and liveness probes

@cla-bot cla-bot bot added the cla-signed label May 20, 2024
@willmostly willmostly requested a review from mosabua May 20, 2024 20:32
@willmostly willmostly merged commit 2b423b1 into trinodb:main May 23, 2024
2 checks passed
@github-actions github-actions bot added this to the 10 milestone May 23, 2024
@ebyhr
Copy link
Member

ebyhr commented May 27, 2024

@willmostly Please use Rebase and merge when merging the PR.

@mosabua
Copy link
Member

mosabua commented May 27, 2024

Or if you need to use squash and merge - make sure to reword message properly and remove the PR number in the title - see https://trino.io/development/process#maintainer-processes

also cc @vishalya and @Chaho12

prakhar10 pushed a commit to prakhar10/trino-gateway that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants