Import code from lyft/presto-gateway #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you actually reword the commit message to the title "Import code from lyft/presto-gateway" and have all the details from the PR description as bullet item points in the commit message? That way the reference is in the git repo history rather than just the PR.. |
- This is the base version for trino-gateway, it is a copy of the code from [https://github.com/lyft/presto-gateway v1.9.5](https://github.com/lyft/presto-gateway/tree/69ac14b888c9caff96daa7d22d2354adbc2a87de) (commit 69ac14b). - This code is available under [Apache License 2.0](https://github.com/lyft/presto-gateway/blob/69ac14b888c9caff96daa7d22d2354adbc2a87de/LICENSE) that allows me to copy this version and submit it as a PR for the trino-gateway project run by trino community. - I along with the Trino community acknowledge the contributions from the authors of this code and thank them for their time and effort which helped us start with trino-gateway. - The full list of contributors is here - https://github.com/lyft/presto-gateway/graphs/contributors
vishalya
changed the title
|
Changed the commit message as well as the PR title. |
|
Merging as is .. code improvements and more will follow later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the base version for trino-gateway, it is a copy of the code from https://github.com/lyft/presto-gateway v1.9.5 (commit 69ac14b). This code is available under Apache License 2.0 that allows me to copy this version and submit it as a PR for the trino-gateway project run by trino community.
I along with the Trino community acknowledge the contributions from the authors of this code and thank them for their time and effort which helped us start with trino-gateway.
The full list of contributors is here - https://github.com/lyft/presto-gateway/graphs/contributors