Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProxyBackendConfiguration #404

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Remove ProxyBackendConfiguration #404

merged 1 commit into from
Jul 11, 2024

Conversation

oneonestar
Copy link
Member

Description

Clean up unused configs after migrating to Airlift.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jul 7, 2024
mosabua
mosabua approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. While we are ripping this apart .. should we also address #408 for the affected class. I am fine with merging this and doing that work later or doing it in this PR. Whatever works for you.

@oneonestar
Copy link
Member Author

I'd like this PR to focus on cleaning up unused configs.

@oneonestar oneonestar merged commit 4c40750 into trinodb:main Jul 11, 2024
2 checks passed
@oneonestar oneonestar deleted the star/simplify_proxy_config branch July 11, 2024 02:17
@github-actions github-actions bot added this to the 10 milestone Jul 11, 2024
@mosabua
Copy link
Member

mosabua commented Jul 11, 2024

I'd like this PR to focus on cleaning up unused configs.

Sounds good.

@mosabua mosabua mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oneonestar @mosabua