Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix development environment configs #53

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Sep 22, 2023

Upgrade docker-compose file version

Specify PGUSER=trino_gateway_db_admin in postgresql so that it doesn't use current OS user as database user name.

Specify PGDATABASE=trino_gateway_db so that it doesn't use user name as DB name to access in default.

  • FATAL: database "trino_gateway_db_admin" does not exist

Update mysql healthcheck cmd (needs pwd)

  • Mysql keeps logging [Note] Access denied for user 'root'@'localhost' (using password: NO)

Add support for development using m1

@cla-bot cla-bot bot added the cla-signed label Sep 22, 2023
@mosabua
Copy link
Member

mosabua commented Sep 22, 2023

Awesome .. I will look more in detail tomorrow

localdev/docker-compose.yml Show resolved Hide resolved
localdev/docker-compose.yml Outdated Show resolved Hide resolved
localdev/docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor updates.. then ready to go.

localdev/docker-compose.yml Outdated Show resolved Hide resolved
localdev/docker-compose.yml Outdated Show resolved Hide resolved
@Chaho12 Chaho12 force-pushed the feature/jaeho.yoo/fix_dev_env branch from f89f4dc to 56b5f7e Compare September 24, 2023 14:34
@Chaho12
Copy link
Member Author

Chaho12 commented Sep 24, 2023

Two minor updates.. then ready to go.

Updated comments!

@mosabua mosabua merged commit 5883285 into trinodb:main Sep 24, 2023
2 checks passed
@Chaho12 Chaho12 deleted the feature/jaeho.yoo/fix_dev_env branch September 25, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants