-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug on create backend to support external URL #76
Fix bug on create backend to support external URL #76
Conversation
8cc22b2
to
1d6b8bf
Compare
Can you also review @willmostly and @vishalya .. from my perspective this looks good. |
Can you change commit message to these maybe
|
1d6b8bf
to
d79762b
Compare
Rebased and changed commit message as you said :) |
Thanks for this fix. Can we also change the view to use the See #81 for context. |
@Chaho12 can you please resolve the conflict @willmostly @vishalya @andythsu - can I get your review with your input |
@lambrospetrou I think it would be good to show both in the UI. This can be done via a separate PR by @Chaho12 or yourself or whoever. |
@lambrospetrou you can have a go to fix it! Or i can do it next week or so cause am off for holiday for the rest of the week. |
d79762b
to
74572dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I was looking at some PRs from lyft/gateway to see any improvements that can be made and noticed that
externalUrl
was not added on create.If the user wanted to set external url as Gateway API guide saids, I need to create add backend, then edit external url.
There was no issue code-wise until now because proxyTo conf (a.k.a backend_url) was used instead of external_url
Also updated docs/gateway-api docs as it has typos/curl syntax issue
FYI.
Test fails until #74 is merged.PR is merged and test is success