Support JWT authentication #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
jwt
branch
4 times, most recently
from
b922098
to
76f09a6
Compare
nineinchnick
force-pushed
the
jwt
branch
2 times, most recently
from
3d7cfda
to
6f5001f
Compare
|
@nineinchnick please rebase |
|
@wendigo good to go, the one failure is a flaky test. I'll see if I can adress that later |
|
@nineinchnick please rebase, there is a conflict |
|
@wendigo green again |
|
Thanks for running with this @nineinchnick |
|
My main motivation is how quickly I can get reviews in this repo :D |
|
@wendigo PTAL. After you merge this, can you do a new release? It requires pushing a new tag. |
wendigo
reviewed
May 3, 2024
README.md
Outdated
| @@ -11,7 +11,7 @@ Trino, and receive the resulting data. | |||
|
|
|||
| * Native Go implementation | |||
| * Connections over HTTP or HTTPS | |||
| * HTTP Basic and Kerberos authentication | |||
| * HTTP Basic, and Kerberos authentication | |||
There was a problem hiding this comment.
BTW I ran the Vale linter on this Readme, same one we use for Trino docs
wendigo
reviewed
May 3, 2024
wendigo
reviewed
May 3, 2024
wendigo
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #110.
I added certificate generation to be able to run integration tests. Statically generated certificates cannot be used, since on macOS they could only be valid for 1 year, which would require regenerating them.
I also refactored
trino/integration_tls_test.goto avoid using the reverse proxy.Fixes #59