Asyncio-compatible version

[samuelscortez0616]

Hi,

I was wondering if it would be possible to have a version that is compatible with asyncio that can be pooled with other tasks. This would really help improve performance as I often to run queries both on Presto and Postgresql connections. Thank you!

[ggreg]

Yes I was thinking of getting rid of Python2 (#5) support and when moving to Python3-only (#4), add support for asyncio.

[mvanderlee]

It's not PR ready, but I created an asyncio fork here: https://github.com/mvanderlee/trino-python-client/tree/py3-async

I've now created a standalone project: https://github.com/mvanderlee/aiotrino

[mvanderlee]

I've cleaned it up, got the builds passing and deployed it as aiotrino on pypi.
Based on the amount of work required, I think it makes sense as a second package instead of integrating Asyncio into the current client.
I'd gladly transfer aiotrino to the trinodb community if requested.

[ShH01m3s]

Hi! Thanks a lot for the aiotrino module! :)
Do you plan to add OAuth2Authentication authentication support to the backlog?

[mvanderlee]

@ShH01m3s I am not planning on it. I have split it to it's own repo, so feel free to submit a PR: https://github.com/mvanderlee/aiotrino

[pw24]

@ShH01m3s I am not planning on it. I have split it to it's own repo, so feel free to submit a PR: https://github.com/mvanderlee/aiotrino

Hi. I've tried out the library as to benefit from making multiple requests concurrently from a python client perspective. After doing so, I just added a JWTAuthentication class similar to the one used in this trino package so that a client can just pass in their jwt tokens for requests. @ShH01m3s, this likely addresses your request as well?

Just need a PR please (pull request).

[hashhar]

There are no plans to add asyncio compatible client for now. Closing for now. We can revisit this in future.

For now there is an aiotrino client available outside of the main project for people who want to try out asyncio.