Type hints for types and mapper modules #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
force-pushed
the
hashhar/mypy
branch
2 times, most recently
from
c614b3d
to
01f15c0
Compare
This additionally helps make mypy happy.
The name of a parameter is significant unless it's a positional-only parameter.
hovaesco
approved these changes
Feb 5, 2024
|
@hovaesco Addressed comments. Only last commit has changed. |
hovaesco
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add type hints for mapper and types modules and enables mypy there.
This uncovered some dead code / possibly broken code regarding handling of ambiguous date-time values. This will be fixed separately in a follow-up.
Release notes
(x) This is not user-visible or docs only and no release notes are required.