Skip to content

Commit

Permalink
Fix flakiness in TestIcebergNessieCatalogConnectorSmokeTest
Browse files Browse the repository at this point in the history
Due to concurrent commits, the default retry count (4) may not be
 sufficient for the commits to succeed.
The `TestIcebergNessieCatalogConnectorSmokeTest`, inheriting
concurrent execution mode from `AbstractTestQueryFramework`
is the root cause of the problem. This was addressed by overriding
 it to execute in a single thread.
  • Loading branch information
ajantha-bhat authored and wendigo committed Apr 30, 2024
1 parent 0deec3f commit 2b88e53
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;
import org.junit.jupiter.api.parallel.Execution;

import java.io.IOException;
import java.nio.file.Files;
Expand All @@ -42,8 +43,10 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.jupiter.api.Assumptions.abort;
import static org.junit.jupiter.api.TestInstance.Lifecycle.PER_CLASS;
import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;

@TestInstance(PER_CLASS)
@Execution(SAME_THREAD)
public class TestIcebergNessieCatalogConnectorSmokeTest
extends BaseIcebergConnectorSmokeTest
{
Expand Down

0 comments on commit 2b88e53

Please sign in to comment.